Skip to content

fix(DateTimePicker): can't clear value when set MinValue #6428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2025
Merged

fix(DateTimePicker): can't clear value when set MinValue #6428

merged 3 commits into from
Jul 16, 2025

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jul 16, 2025 •
edited by sourcery-ai bot
Loading

Link issues

fixes #6423

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Fix the DateTimePicker’s clear functionality when a MinValue is set and update tests accordingly.

Bug Fixes:

  • Fix DateTimePicker unable to clear its value when a MinValue is specified by falling back to the MinValue instead of DateTime.MinValue

Enhancements:

  • Update unit tests to use async Task and await for interactions on DateTimePicker

Tests:

  • Add a test scenario verifying the clear button resets the value when MinValue is set

@bb-auto bb-auto bot added the bug Something isn't working label Jul 16, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 16, 2025 •
edited
Loading

Reviewer's Guide

This PR ensures the DateTimePicker can clear its value even when a MinValue is defined by falling back to MinValue instead of DateTime.MinValue and adjusts the unit tests to use async/await and cover the new clear behavior.

File-Level Changes

Change Details Files
Adjusted unit tests to properly await rendering interactions and cover the clear behavior when MinValue is set
  • Changed OnClear_Ok signature from void to async Task
  • Updated cut.InvokeAsync calls for cell.Click and clear.Click to be awaited
  • Added a test scenario to set MinValue and verify clear button clears the input
 test/UnitTest/Components/DateTimePickerTest.cs
Fixed SelectedValue initialization to use MinValue as the fallback when Value is null
  • Replaced hardcoded DateTime.MinValue fallback with MinValue ?? DateTime.MinValue in SelectedValue assignment
 src/BootstrapBlazor/Components/DateTimePicker/DateTimePicker.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6423 The DateTimePicker component should allow clearing the selected value when MinValue is set to DateTime.Today and the value can be null. ✅
#6423 The DisplayDisabledDayAsEmpty property should work correctly when MinValue is set. ✅
#6423 When Value is null, SelectedValue should be initialized to MinValue if MinValue is not null, otherwise DateTime.MinValue. ✅

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the 9.8.0 milestone Jul 16, 2025
sourcery-ai[bot]
sourcery-ai bot approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jul 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3570038) to head (408bfdc).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #6428   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          746       746           
  Lines        32225     32225           
  Branches      4554      4554           
=========================================
  Hits         32225     32225
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit 9328c8a into main Jul 16, 2025
7 checks passed
@ArgoZhang ArgoZhang deleted the fix-datetime branch July 16, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] approved these changes

Assignees

@ArgoZhang ArgoZhang

Labels

bug Something isn't working

Projects

None yet

Milestone

v9.8.0

Development

Successfully merging this pull request may close these issues.

bug(DateTimePicker): 组件 MinValue 设置为DateTime.Today 并且值可为空时，无法清空

2 participants

@ArgoZhang